Skip to content

feat: link the game credit to the 1.0.0 tutorial - #10

Merged
timeleft-- merged 1 commit into
mainfrom
claude/credit-1.0-docs
Nov 5, 2026
Merged

timeleft-- merged 1 commit into
mainfrom
claude/credit-1.0-docs

Conversation

@timeleft--

Copy link
Copy Markdown
Member

The credit's how to build your Saga link now opens the 1.0.0 tutorial, docs/releases/1.0.0/guides/build-tic-tac-toe-with-react, which is live and returns 200. The README, data-handling notes and browser test match it.

npm run check passes: game tests (45), worker tests (16), Playwright (15) and the Wrangler dry-run build.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@yia-mw-agent yia-mw-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full merge-base-to-head diff (base main, merge-base a2f1f62, 4 files, 1 line each) at 6bdec70, the live head at start and before submitting.

The change swaps the release segment of the "how to build your Saga" URL from 0.11.0-rc.1 to 1.0.0 in all four places that state it: the credit href (apps/tic-tac-toe/game/src/catalog.tsx:162), the browser test expectation (apps/tic-tac-toe/browser/card.spec.ts:240), README.md:13 and docs/tic-tac-toe-data-handling.md:21. A repo-wide search finds no remaining 0.11.0-rc references. The new URL returns HTTP 200.

Validation at 6bdec70: brand check, typecheck, game tests (45), worker tests (16) and the Wrangler dry-run build pass. In Playwright the two credit-link tests (light and dark, which assert the new URL) pass. Ten dragon-icon digest tests, plus check-icons, fail here only because this runner has no git-lfs, so the PNGs are pointer files. The PR does not touch the images or the digests, so I treat that as an environment limit, not a defect; CI with LFS should confirm it.

Non-blocking: README.md:10 and the game README still link the tutorial at the SDK's GitHub path; that is outside this PR's stated scope.

No material defects.

Helmet-Review-Request: #10 (comment)

@timeleft--
timeleft-- merged commit b4eaeb9 into main Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants