Repository navigation
feat(mcp): add the ChatGPT publication input with Ansari's icon - #6
Closed
timeleft-- wants to merge 1 commit into
Closed
timeleft-- wants to merge 1 commit into
timeleft-- wants to merge 1 commit into
Conversation
Add saga-publication.json, the release input SAGA's saga publish tool uses to prepare the ChatGPT plugin package. It names Ansari's listing, the Dev endpoint and the build, and points both the logo and the composer icon at assets/ansari-plugin-icon.svg: the unchanged floral mark from brand-mark.ts on the card's green. Supplying both keeps SAGA's default artwork out of Ansari's package. The release gate's version mirror moves from a plugin/plugin.json this repository never had to the release input, and also requires its endpoint.expectedServer.version to match the app version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
approved these changes
Oct 29, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full merge-base-to-head diff against codex/ansari-faithful-answers-076 (5 files, +75/-17) at e632702. I found no material defects.
Helmet-Review-Request: #6 (comment)
What I checked:
check-release.mjs: the oldplugin/plugin.jsonmirror is replaced byapps/mcp/saga-publication.jsoninRELEASE_FILES,RELEASE_CONTENTandvalidateRelease. The content screen nulls bothversionandendpoint.expectedServer.version, so a release changes only the version fields. A missingendpointis handled. No references toplugin/plugin.jsonremain in the repository.saga-publication.json: valid JSON.versionandexpectedServer.versionare both 0.16.6, matchingpackage.json. Both asset paths exist.- Icon: it carries the nine brand-mark paths on the
#15583erounded square, as the description says. - Tests: the updated release tests cover version drift in both fields and the non-version-change refusal on the new file.
Validation run at this head (from apps/mcp):
tsx --test test/release.test.ts: 32/32 passeslint .: cleantsc --noEmit: cleannode scripts/check-release.mjs --target dev: "Release check passed for dev"
Non-blocking notes:
- The comment in
check-release.mjsstill says "the three small release files" whileRELEASE_FILESlists four entries includingpnpm-lock.yaml; this wording predates the PR. - As the description says, the
endpoint.viewsandendpoint.tools(destructiveHint) checks are open, so the plugin ZIP can't be produced yet. This is outside this PR's scope.
Member
Author
|
Superseded by #8: the same commit rebased onto develop at 3a072da, now that iaser-ai#323 has merged. A new branch avoids force-pushing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the plugin icon from MachineWisdomAI/ansari-faithful-answers#105 to iaser-ai#323, using SAGA's
saga publishtool instead of a hand-writtenplugin/folder.Changes
apps/mcp/saga-publication.json. The release inputsaga publish prepare --target chatgptreads.ansari-mcp0.16.6.dist/view.html.apps/mcp/assets/ansari-plugin-icon.svg. The nine paths fromassets/brand-mark.ts, unchanged, on the card's#15583egreen rounded square, with the same bytes as chore(porch): 100 complete iaser-ai/ansari#105's icon. Bothassets.logoandassets.composerIconpoint at it. With feat: default prepared ChatGPT plugins to SAGA branding saga-a2ui#339, a missing field falls back to the SAGA seahorse, so Ansari has to supply both.plugin/plugin.json, a file this repository never had. It now checks the release input'sversionandendpoint.expectedServer.versionagainstpackage.json. The release-files screen blanks both of those fields.The artwork notice is unchanged: the icon is the MIT-licensed attribution mark that
assets/NOTICE.mdalready covers.Validation
saga publish prepare --target chatgptat saga-a2ui#339's head (54b8cab), against the Dev endpoint. The input, discovery, identity (ansari-mcp0.16.6), manifest, MCP config, listing, assets, components and secrets checks all pass. "The logo and composer icon are present, square, valid and within the size limits."assemblePackageon this input:plugin.json,mcp.jsonandassets/ansari-plugin-icon.svg, byte-identical to the committed file. There's no SAGA seahorse.interface.logoandinterface.composerIconare both./assets/ansari-plugin-icon.svg.endpoint.views: Dev still serves thefc40c24build, not this one. Preparing a package needs Dev redeployed from this branch.endpoint.tools: the ChatGPT plugin guidelines wantdestructiveHintset explicitly. The tool keeps the legacy server'sreadOnlyHintandopenWorldHintonly, as Amr's parity item asked, so this is left for a decision.check-release --target devpasses. With the input's version set to 0.16.5 it fails with "saga-publication.json version (0.16.5) differs".Nothing was deployed, uploaded or submitted.
🤖 Generated with Claude Code