Repository navigation
build(mcp): install SAGA 1.0.0-rc.1 from the npm registry - #14
Merged
Merged
Conversation
Ansari moves from the committed candidate tarballs to the published @saga-a2ui/react-mcp-stack@1.0.0-rc.1 and its four siblings. The candidate tarballs, their five root overrides and the Dockerfile copy step are removed. The SDK's documented dompurify and @hono/node-server overrides stay. The packaging test is registry-only again. It checks the lockfile against the integrity values read from npm (`npm view @saga-a2ui/<name>@1.0.0-rc.1 dist.integrity`), and the lockfile records exactly those values. sdk-identity.mjs is back to its registry-only form. The Beta release gate now passes with registry verification; Production still refuses the prerelease. App version 0.17.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
approved these changes
Nov 5, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full merge-base-to-head diff (merge-base c6c6938 = develop tip, 14 files) at 07f7616. No material defects.
Verified:
- The five SAGA integrity values in
pnpm-lock.yamlandapps/mcp/test/packaging.test.tsmatchnpm view @saga-a2ui/<name>@1.0.0-rc.1 dist.integrityfor core, components, mcp, react and react-mcp-stack. - The
file:overrides,apps/mcp/candidates/tarballs and the Dockerfile COPY step are fully removed. The lockfile has no remainingfile:/tarball SAGA entries. Thedompurify,@hono/node-serverand@a2ui/markdown-itoverrides are kept. pnpm install --frozen-lockfile --strict-peer-dependencies --filter ansari-mcp...succeeds.ansari-mcplint and typecheck pass.pnpm --filter ansari-mcp test(build, worker build, unit and packaging tests) passes.- Browser checks: 78 checks, 0 errors.
check:release --target betapasses, with all five packages verified against the registry.--target productioncorrectly refuses the prerelease, as the description states.- Version bump to 0.17.1 is consistent across
package.jsonandversion.ts, and the walkthrough text matches. The walkthroughSOURCE_BASEcommit 0536407 is an ancestor of the head.
Non-blocking: apps/mcp/scripts/check-release.mjs still carries candidate/candidates/ tolerance logic and Dev messaging. It is harmless, since the repository commits no candidates, but it could be trimmed in a follow-up.
Helmet-Review-Request: #14 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Ansari from the committed SAGA candidate tarballs to the published
1.0.0-rc.1(npmnext). This is the step #12 left for publication.Change
@saga-a2ui/react-mcp-stackis pinned to1.0.0-rc.1, resolved with its four siblings from the public registry.apps/mcp/candidates/, the five SAGA overrides in the rootpnpm-workspace.yamland the Dockerfile copy step are removed. The SDK's documenteddompurifyand@hono/node-serveroverrides stay.npm view @saga-a2ui/<name>@1.0.0-rc.1 dist.integrity), and the lockfile records exactly those values. The candidate-only paths in the test and inscripts/sdk-identity.mjsare deleted.registry/1.0.0-rc.1.The card stays at
ui://views/answer-card.v1.html.Verification
pnpm install --frozen-lockfile --strict-peer-dependencies --filter ansari-mcp...succeeds.pnpm mcp verifypasses: lint, typecheck, 145 tests and 78 browser checks.bash apps/mcp/scripts/verify-container.shpasses; the root-context Docker build servesui://views/answer-card.v1.html.pnpm check:release --target betapasses, verifying all five packages against the npm registry.--target productionrefuses the prerelease, so Production waits for the stable SAGA release.🤖 Generated with Claude Code