Skip to content

docs(mcp): a diagnostics origin keeps the card's address - #13

Merged
timeleft-- merged 1 commit into
developfrom
claude/mcp-readme-diagnostics-address
Nov 5, 2026
Merged

timeleft-- merged 1 commit into
developfrom
claude/mcp-readme-diagnostics-address

Conversation

@timeleft--

Copy link
Copy Markdown
Member

Since the card is served at its compatibility line (ui://views/answer-card.v1.html), a diagnostics origin changes the card's bytes and permissions but not its address. Two README lines still said the address changes; this corrects both. Docs only; no version bump.

🤖 Generated with Claude Code

…ons, not its address

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@yia-mw-agent yia-mw-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full merge-base-to-head diff of PR #13 (base develop, 1 file: apps/mcp/README.md, 2 lines) at 8ebc147.

No material defects. Both corrected README statements (the MCP_VIEW_DIAGNOSTICS_ORIGIN table row and the "Card reports, diagnostic card only" paragraph) now say a diagnostics origin changes the card's bytes and permissions, not its address. This matches apps/mcp/src/server/view-artifact.ts: prepareAnswerView passes the same VIEW_FILENAME and VIEW_MAJOR in the diagnostics and closed branches, and only the HTML, connect-src and csp.connectDomains differ. It also agrees with the unchanged README lines 40-41 and 107. The remaining "ansari-diagnostics address" wording refers to the beacon URL meta tag, not the card's ui:// address. The change is docs only, so no version bump is needed.

Non-blocking: CI checks for auth, api and MCP application were still pending when I reviewed; the change touches no code.

Helmet-Review-Request: #13 (comment)

@timeleft--
timeleft-- merged commit c6c6938 into develop Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants