Open
Conversation
Changed constexpr to enum
Addeec constexpr to defined constants. FIxed warning C5055 after enum changes.
Fixed wasrning on unintialized variables. Templated clrmem() macro
moved include to top of file.
changed macros to class member functions.
changed defines to enum/constexpr.
moved function to global.h header.
changed final references of STAT_PROP to MAX_ prefix
odd location in if else required multiple initializations.
named some enums
changed define to constexpr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partial completion. Changed a bit more than I probably should have, but standards indicate that changing to typesafe non-macros should be a good end goal, should it be able to be done safely.
For now, left a lot of the more complex macros, such as the loggers/message and engine callbacks alone.
Changed as many macro functions to class member/file functions / unrolled macros where possible.
Left thirdparty/public/engine files alone for the most part.
Changed all the vec3_t to Vector class, removed all #define constants I could with constexpr/enum where possible.
Resolved a few header inclusion issues / duplicated defines.
changed vector class to be able to be initialized as constexpr class objects.
I can compile without issue and some light testing indicates general stability, but comprehensive testing needs to be completed.
Script events in edana have tested successfully, etc.
FALSE is still cast as int
TRUE is still defined as int
NULL is still defines as int
future issue recommended to change these to true/false/nullptr/0 where applicable