MPAS MUSICA namelist option for MICM configuration #1376
+42
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed logging. Registry.xml: Added a MUSICA namelist record gated by MPAS_USE_MUSICA with the `config_micm_file` option so the MICM JSON path can be provided through the standard configuration system. mpas_atm_chemistry.F: Removed the hardcoded `chapman.json`, pull the MICM file path from the configs pool, then propagate errors from `musica_init` via `mpas_log_write` to fail when initialization breaks. mpas_musica.F: Track the species description pointer and log each MICM species name from `state%species_ordering` so users can verify the runtime mapping.
mgduda
requested changes
Nov 11, 2025
mgduda
requested changes
Dec 15, 2025
|
|
||
| #ifdef MPAS_USE_MUSICA | ||
| <nml_record name="musica" in_defaults="true"> | ||
| <nml_option name="config_micm_file" type="character" default_value="" |
Contributor
There was a problem hiding this comment.
While I agree that we should let the default value be an empty string, should we also add logic in musica_init to not try to initialize MUSICA if config_micm_file is an empty string? Otherwise, would there be another way to not call MUSICA in a particular simulation when MPAS was compiled with MUSICA=true?
Author
There was a problem hiding this comment.
- Added musica_is_initialized flag (line 32)
- Added early return when config file is empty, with log message (lines 69-75)
- Added logging of the config file path (line 80)
- Set musica_is_initialized = .true. after successful init (line 93)
- Added guard in musica_step (line 114)
- Added guard in musica_finalize (line 137)
2. Added early return when config file is empty, with log message (lines 69-75) 3. Added logging of the config file path (line 80) 4. Set musica_is_initialized = .true. after successful init (line 93) 5. Added guard in musica_step (line 114) 6. Added guard in musica_finalize (line 137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MICM configuration is now driven by a MUSICA namelist option with added logging.
Registry.xml: Added a MUSICA namelist record gated by MPAS_USE_MUSICA with the
config_micm_fileoption so the MICM JSON path can be provided through the standard configuration system.mpas_atm_chemistry.F: Removed the hardcoded
chapman.json, pull the MICM file path from the configs pool, then propagate errors frommusica_initviampas_log_writeto fail when initialization breaks. mpas_musica.F: Track the species description pointer and log each MICM species name fromstate%species_orderingso users can verify the runtime mapping.