feat(sunset): one-click export sign-in, and drop Sign in from the site nav - #1802
Merged
Merged
Conversation
/login has nothing to choose between when AUTH_TYPE is GOOGLE -- it renders a page whose only content is a single Google button. Export is the one action the 30-day tail exists for, so /sunset now goes straight to the provider and leaves that page to LOCAL deployments, where the password form is real content. The page needs its own layout because RuntimeConfigProvider is opt-in per route, the way /login, /register and /dashboard already do it.
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
It was the bar's only filled button, so on /downloads the loudest control on the page asked visitors to log in, directly above the line "One installer, no account, no cloud". There is no account to sign in to. The one audience that still needs it is hosted users exporting during the wind-down, and /sunset carries its own sign-in button for them. They reach that page from the launch email, the legacy desktop app, or the /dashboard redirect, so the nav entry was a third path to somewhere they were already being sent.
CREDO23
changed the title
The page hands out a free app, so the form is an offer rather than a gate: the OS grid and the releases link stay exactly where they were, and the note says outright that the installers below need no address. It reuses /license's TrialForm rather than growing a second one. The only thing that differs between the two pages is the line under the field, so that becomes a prop and /license keeps its own wording as the default. The note is also width-capped and given more room above it, since at full container width it ran as one long line. The hero's OS auto-detect button goes: with the form above it and the platform grid below, it was the third way to start the same download. Individual's trial button on /pricing now names the length, matching the FAQ and meta description on that page.
The site has to link the release by tag: /releases/latest is pinned to the legacy 0.0.x app for good, so it will never point at 2.x. The tag lives under surfsense_web/ rather than being read from surfsense_local/VERSION because the web image builds with context: ./surfsense_web, so nothing outside that directory exists at build time. bump-version.sh writes it alongside the three manifests it already updates, which also rebuilds the web image: that path is a trigger in docker-build.yml.
/releases/latest is pinned to the legacy v0.0.40 for good, so that the old desktop updater never sees 2.x. The website resolved the same pointer, which meant /downloads handed every visitor the discontinued hosted client -- and publishing 2.0.0 with the latest box unchecked means it would never have corrected itself. The lookup is now /releases/tags/<tag>, with the tag coming from app-release.ts. It also moves to the server with an hour of revalidation: the browser call was unauthenticated against a 60/hour per-IP limit, so one office behind a shared address emptied the grid for everyone on it, and the installer links only appeared after hydration on a page that is an SEO target. app-release.ts absorbs the asset labels and the releases URL because desktop-download-utils.ts has hooks at module scope, so a server component importing it fails to compile. The client hook stays for the dashboard sidebar, now resolving the same tag. No assets means the platform section is hidden and the releases link carries the page, rather than placeholder rows that never resolve. That is what /downloads shows today, since v2.0.0 is not cut yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes from testing
SUNSET_MODElocally, and they depend on each other.Signing in to export is one click
Clicking Sign in to export on
/sunsetwent to/login, which on a Google-only deployment renders a page containing a logo, a heading and one button. Three clicks and two page loads for the single action the 30-day export window exists for./sunsetnow goes straight to/auth/google/authorize-redirectwhen the runtime auth type isGOOGLE, and still routes to/loginforLOCAL, where the password form is real content. Both call sites use it — the first click and the 401 retry inside the export — so an expired session behaves the same way.trackLoginAttempt("google")came along with the redirect, so the analytics event is unchanged.The return leg already worked and is untouched: Google's callback lands on
/dashboard, and the sunset redirect bounces it to/sunset, where the button reads "Export account".The new
sunset/layout.tsxis required rather than incidental.RuntimeConfigProvideris opt-in per route —/login,/register,/desktop/loginand/dashboardeach declare it — and without ituseIsGoogleAuth()hits the provider's guard and/sunset500s. Same three lines as/login's layout. It makes the page dynamically rendered, which is fine: it isnoindexand reads a per-request cookie regardless.Sign in leaves the nav and footer
It was the bar's only filled button, so on
/downloadsthe loudest control on the page asked visitors to log in — directly above the line "One installer, no account, no cloud".HomePillarssays "there is no sign-up, no email, no workspace to be invited to", and the page description says "no account". The button contradicted all of it, and after T+30 the accounts are deleted and it points at nothing.The one audience that still needs a login is hosted users exporting during the wind-down, and they reach
/sunsetfrom the launch email, the legacy desktop client, or the/dashboardredirect — then use that page's own button, which the first change just made a single click. The nav entry was a third path to somewhere they were already being sent.SIGN_IN_URLand the now-unusedHomeButtonimport go with it.Checks
Biome and
tsc --noEmitclean. Verified on a local stack withSUNSET_MODE=1:/sunsetreturns 200 and reaches Google without the intermediate page;/downloadsreturns 200 with no "Sign in" anywhere on it.