Skip to content

fix(dfns): migrate utl-obs ids to a union of cellid, index and boundname - #380

Merged
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:obs-id-union
Oct 5, 2026
Merged

wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:obs-id-union

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Make utl-obs's id/id2 an untagged union of the kinds of id they can hold. The v1 DFNs had these marked as numeric_index which the migration dropped.

v1 marks utl-obs's id/id2 as strings with numeric_index, which the
migration dropped since index isn't valid on a string. They now become
an untagged union of the kinds of id they can hold; the codec picks the
arm from the parent package and the token.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wpbonelli wpbonelli added this to the 1.10.0 milestone Oct 5, 2026
@wpbonelli wpbonelli added the bug Something isn't working label Oct 5, 2026
@wpbonelli
wpbonelli marked this pull request as ready for review October 5, 2026 22:11
@wpbonelli
wpbonelli merged commit f3aeebe into MODFLOW-ORG:develop Oct 5, 2026
15 checks passed
@wpbonelli
wpbonelli deleted the obs-id-union branch October 5, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant