Repository navigation
fix(dfns): restore gwf-sfr connectiondata ic shape - #377
Merged
Merged
Conversation
MODFLOW-ORG/modflow6#2923 changed gwf-sfr's connectiondata `ic` shape from `(ncon(ifno))` to IDM's deferred `(:)`, which the v2 schema rejects, so no DFN set including it validates. Map it back via _V1_SHAPE_FIXES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MODFLOW-ORG/modflow6#3021 (LAK IDM integration) changes gwf-lak's connectiondata shape from `(sum(nlakeconn))` to `(nlakeconn)`, a packagedata column rather than a dim, which silently drops the list shape and the derived nlakeconn dim. Map it back via _V1_SHAPE_FIXES, now also applied to recarray shapes in _infer_list_shape_dims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODFLOW-ORG/modflow6#2923 changed gwf-sfr connectiondata
icshape from(ncon(ifno))to(:), accommodate this in the migration. And a similar defensive fix for gwf-lak connectiondata given MODFLOW-ORG/modflow6#3021