fix(dfns): mark blocks optional - #376
Merged
Merged
Conversation
MF6 reads SFR CROSSSECTIONS/DIVERSIONS/INITIALSTAGES, LAK OUTLETS and IMS NONLINEAR/LINEAR with blockRequired=.false., but their v1 fields aren't all marked optional, so the derived Block.optional came out false. A writer that emits required blocks even when empty then writes e.g. an empty SFR DIVERSIONS block, which MF6 rejects. Mark these blocks' fields optional during migration until the upstream DFNs are fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MF6 reads SFR CROSSSECTIONS/DIVERSIONS/INITIALSTAGES, LAK OUTLETS and IMS NONLINEAR/LINEAR with
blockRequired=.false., but these aren't all marked optional in the DFNs. Mark them optional during migration until the upstream DFNs are fixed