fix(dfns): scope package dims to their component - #375
Merged
Merged
Conversation
The dev2 migration gave every dimensions-block integer the scope implied by the component's parent, so any package under a model declared its dims at model scope (and any under the simulation at simulation scope). Package dims like nseg, numgnc and maxbound then leaked into every other package's inherited dims, and names like maxbound were declared model-wide by dozens of components. utl-laktab/utl-sfrtab's nrow/ncol even collided with the discretization's at simulation scope. Only the discretization's grid dims and TDIS's nper are shared; everything else is now component-scoped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration gave every dimension the scope implied by the component's parent. Only the discretization's grid dims and TDIS's nper should be shared, everything else component scoped.