fix(dfns): support signed index - #374
Merged
Merged
Conversation
v1's support_negative_index (only gwf-sfr's connectiondata `ic`) was dropped by the migration, leaving `ic` as a plain index. A consumer translating it 1-based -> 0-based turns -2 into -3, and there's no 0-based signed equivalent: the sign and magnitude are two facts. - schema: `index` on Integer and integer Array may be "signed": the magnitude is a 1-based index and the sign carries a meaning of its own, defined by the field's description. - migration: map numeric_index + support_negative_index to index="signed", and backfill fk="packagedata.ifno" on `ic` (applying to the magnitude). _FK_BACKFILL now takes several entries per component and accepts integer array columns. - docs: describe "signed" under both `index` sections, and array fk on list-record columns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DFNs'
support_negative_indexattribute was dropped, leaving gwf-sfr connectiondataicas a plain index. This is inadequate because the sign and magnitude are two different facts.Support
index="signedon Integer and integer Array, indicating the magnitude is a 1-based index and the sign carries a meaning of its own, as defined by the particular field