feat(dfns): model array-based aux as a list of named arrays - #371
Merged
Merged
Conversation
Array-based stress packages (gwf-rcha, gwf-evta, gwf-*g) read one grid array per auxiliary variable, each introduced by the variable's name, not a single array tagged AUX. Migrate the period `aux` field to an optional tagged list of (auxname, aux) records, bounded by the auxiliary count, with `auxname` an untagged string keyed to `options.auxiliary`. Relax the spec to support this with existing constructs: - a string `fk` may target a string array, whose entries are the keys - a record led by such a dynamic keyword is keyword-led, so the list is tagged and may appear among the block's other tagged fields - a dynamic keyword followed by an array spans lines, read like a tagged array whose tag is the key's value Also validate fks in union-item lists, and keep the dev3 memory catalog's BOUND columns from picking up the aux list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer- and grid-array stress packages (gwf-rcha, gwf-evta, gwf-welg, etc) have an array per auxiliary variable. This wasn't represented before. Tweak the spec to accommodate this kind of relationship as a list of dynamically named arrays.