Skip to content

fix: match validate_concepts tables by exact name #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 2 commits into from
+3 −2
Closed

fix: match validate_concepts tables by exact name #2093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7816564
fix: match validate_concepts tables by exact name
Chessing234 Jul 19, 2026
0620244
fix: exact table name match in validate_concepts.sh
Chessing234 Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mimic-iv/concepts/validate_concepts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ fail=0
missing=0
while read -r tbl; do
[ -z "${tbl}" ] && continue
if ! grep -q "^${tbl}," <<< "${ACTUAL}"; then
# exact field match (regex grep can false-hit prefixes)
if ! awk -F, -v t="${tbl}" '$1 == t { found=1 } END { exit !found }' <<< "${ACTUAL}"; then
echo "MISSING: expected table ${DATASET}.${tbl} was not built"
missing=1
fail=1
Expand All @@ -47,7 +48,7 @@ empty=0
while IFS=, read -r tbl rows; do
[ -z "${tbl}" ] && continue
# only validate the tables we actually build (ignore _metadata and any strays)
if grep -qx "${tbl}" <<< "${EXPECTED}" && [ "${rows}" -eq 0 ]; then
if grep -Fxq "${tbl}" <<< "${EXPECTED}" && [ "${rows:-}" -eq 0 ]; then
echo "EMPTY: table ${DATASET}.${tbl} has 0 rows"
empty=1
fail=1
Expand Down
Loading