Skip to content

fix: check $1 not pid in copy_concepts script #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: check $1 not pid in copy_concepts script #2091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mimic-iv/concepts/copy_concepts_to_versioned_schema.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/bash
# This script copies the concepts in the BigQuery table mimiciv_derived to mimiciv_${VERSION}_derived.
if [ -z "$$1" ]; then
if [ -z "$1" ]; then
echo "Usage: $0 <version>"
exit 1
fi
export SOURCE_DATASET=mimiciv_derived
export TARGET_DATASET=mimiciv_$1_derived
export TARGET_DATASET="mimiciv_${1}_derived"
export PROJECT_ID=physionet-data

# check if the target dataset exists
Expand All @@ -19,11 +19,11 @@ if bq ls --datasets --project_id ${PROJECT_ID} | grep -q ${TARGET_DATASET}; then
if [[ "${TABLE:0:2}" == '--' ]]; then
continue
fi
bq rm -f -q ${PROJECT_ID}:${TARGET_DATASET}.${TABLE}
bq rm -f -q "${PROJECT_ID}:${TARGET_DATASET}.${TABLE}"
done
else
echo "Creating dataset ${PROJECT_ID}:${TARGET_DATASET}"
bq mk --dataset ${PROJECT_ID}:${TARGET_DATASET}
bq mk --dataset "${PROJECT_ID}:${TARGET_DATASET}"
fi

echo "Copying tables from ${SOURCE_DATASET} to ${TARGET_DATASET}."
Expand All @@ -33,5 +33,5 @@ do
if [[ "${TABLE:0:2}" == '--' ]]; then
continue
fi
bq cp -f -q ${PROJECT_ID}:${SOURCE_DATASET}.${TABLE} ${PROJECT_ID}:${TARGET_DATASET}.${TABLE}
bq cp -f -q "${PROJECT_ID}:${SOURCE_DATASET}.${TABLE}" "${PROJECT_ID}:${TARGET_DATASET}.${TABLE}"
done
Loading