fix(auth): two TypeError crash paths on malformed IdP claims become audited ClaimsError (BACKLOG #1016) - #244
Merged
Merged
Conversation
…00ing (BACKLOG #1016)
wshallwshall
enabled auto-merge (squash)
August 6, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BACKLOG #1016. Sequenced AFTER #1015 (auth cluster base).
Two TypeError crash paths on malformed IdP responses become a named, audited ClaimsError
(nonce_mismatch / claim_aud). A valid token still validates.
CORRECTED PATH, worth noting because the manifest first recorded it wrongly: the fix is in
messagefoundry/auth/oidc/claims.py, NOT auth/claims.py.
PROVENANCE, stated rather than omitted: the lane BUILT but did not commit -- blocked by the claim
hook requiring the committing worktree to own the claim. The item was re-claimed to the worktree and
committed there. Pre-commit hooks (leak guard, secrets, bandit, ruff) all PASSED; no --no-verify.
Tests were verified IN-LANE via 3-lens verify and falsifications, and were not re-run at
salvage time.