-
Notifications
You must be signed in to change notification settings - Fork 775
ENH: tpx 138 (GROMACS 2026.0) support #5219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
* Add `.tpr` parsing support for GROMACS `2026.0`, which was recently released: https://manual.gromacs.org/2026.0/release-notes/2026/major/highlights.html * I believe this is the first time we bump the `tpx` version support since we added support for parsing positions and velocities from `.tpr` files, so we may want to be particularly careful here.
| 133 28 2024.1 yes | ||
| 134 28 2024.4 yes | ||
| 137 28 2025.0 yes | ||
| 138 28 2026.0 yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I didn't actually check the tpx generation (number 28 here), so we may want to double check that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm following this enum properly, we're on generation 29? https://github.com/gromacs/gromacs/blob/main/src%2Fgromacs%2Ffileio%2Ftpxio.cpp#L244
(generation is Count-1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: these new .tprs were all produced using gmx convert-tpr with GROMACS built from source at the release tag for version 2026.0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5219 +/- ##
===========================================
- Coverage 92.73% 92.72% -0.01%
===========================================
Files 180 180
Lines 22475 22475
Branches 3190 3190
===========================================
- Hits 20842 20841 -1
- Misses 1176 1177 +1
Partials 457 457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, this looks good to me, just the one tiny thing.
| 133 28 2024.1 yes | ||
| 134 28 2024.4 yes | ||
| 137 28 2025.0 yes | ||
| 138 28 2026.0 yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 138 28 2026.0 yes | |
| 138 29 2026.0 yes |
* Update the TPX generation based on reviewer feedback. Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
I used the suggested changes GUI interface to apply the one suggested documentation change based on reviewer feedback (thanks for checking that.. I'm swamped). |
In 2027, we consider embedding NN weights into TPR, which can get funky, but for now it's just a couple new fields. |
Add
.tprparsing support for GROMACS2026.0, which was recently released:https://manual.gromacs.org/2026.0/release-notes/2026/major/highlights.html
I believe this is the first time we bump the
tpxversion support since we added support for parsing positions and velocities from.tprfiles, so we may want to be particularly careful here.@al42and I just used
gmx convert-tprwith GROMACS 2026.0 on your alanine dipeptide NN potential.tprprovided back in gh-4919. Will that suffice to test out the newtpr"bells and whistles" from GROMACS 2026? The release highlights mention "Expanded support for running simulations with Neural Network Potential models, now including link atom treatment for NNP/MM, pairlist input, and electrostatic embedding models." But for the most part the.tprparsing doesn't seem to need any new shims with the.tprfiles we're currently using.LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: No
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5219.org.readthedocs.build/en/5219/