Maint: Disable build isolation in pip cron tests#5181
Maint: Disable build isolation in pip cron tests#5181Dreamstick9 wants to merge 1 commit intoMDAnalysis:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5181 +/- ##
===========================================
- Coverage 92.72% 92.72% -0.01%
===========================================
Files 180 180
Lines 22472 22472
Branches 3188 3188
===========================================
- Hits 20838 20837 -1
- Misses 1176 1177 +1
Partials 458 458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Thanks for doing this @Dreamstick9 but there's quite a lot to check here rather than just adding the flags back in, I'm unfortunately going to say this is something one of the core developers should be doing rather than going back and forth doing the checks.
|
Thanks @IAlibay! totally understand—CI/build isolation can get tricky with side effects, so it makes sense for a core dev to handle the deep verification. I'll close this PR so you folks can tackle it directly. Thanks for the quick feedback! |
Fixes #5125
Changes made in this Pull Request:
.github/workflows/gh-ci-cron.yamlto include the--no-build-isolationflag in pip install commands.PR Checklist
package/CHANGELOGfile updated? (N/A - Maintenance fix)package/AUTHORS? (Note: My name is added to AUTHORS in my pending PR MAINT: Replace deprecated numpy assertions in coordinates/base.py #5156)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5181.org.readthedocs.build/en/5181/