Fix Xcode 26 layout issue in bolus and carb entry views#68
Merged
Conversation
gestrich
force-pushed
the
fix_xcode26_layout_hstack
branch
from
33fafb2 to
eb711b6
Compare
Wrap amount text fields and unit labels in HStack to ensure the unit text lays out next to the amount. Xcode 26 broke this layout in both BolusInputView and CarbInputView. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gestrich
force-pushed
the
fix_xcode26_layout_hstack
branch
from
eb711b6 to
223da88
Compare
2 tasks
Collaborator
Author
|
Going to merge this today as yesterday's merge will cause regressions in the unit layout for anyone auto-updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 69
Summary
Uandg) was not laying out next to the amount fieldTextField/Textand unit label in anHStackin bothBolusInputViewandCarbInputViewto ensure proper side-by-side layoutSee attached issue for broken views. Below is with this PR on a real device: