Skip to content

feat: object registry and isosurfaces in the 3D view (6.8) - #145

Open
lachlangrose wants to merge 1 commit into
feat/fault-topology-buttonfrom
feat/viewer-object-registry
Open

lachlangrose wants to merge 1 commit into
feat/fault-topology-buttonfrom
feat/viewer-object-registry

Conversation

@lachlangrose

Copy link
Copy Markdown
Member

What

Phase 6.8 of the usability plan.

  • Mesh builders are in a module without Qt (mesh_builders.py). feature_list_widget.py is much smaller.
  • The viewer keeps its objects and their sources in an object registry (object_registry.py). The widgets read and change objects only through it. geometry_object.py is removed.
  • The object list groups the objects by source feature.
  • New "Add isosurface..." in the menu of a model feature. Enter a list of values or a start, an end and a count. One object is added for each value (for example Fault_1_iso_0.50).
  • The value of an isosurface can change in the object properties. Only that object is built again.
  • Docs for the 3D view in docs/usage/interface.md.

Base branch

This PR is stacked on #144 (feat/fault-topology-button).

Tests

  • Unit tests for the registry, the isovalues function and the mesh builders pass (34 tests).
  • tests/qgis/test_viewer_isosurfaces.py is new. I could not run it here because qgis is not installed in this Python.

…ture

Move the mesh builders out of feature_list_widget into a module without Qt,
keep the viewer objects and their sources in an object registry, group the
object list by source feature, and add "Add isosurface..." to the menu of a
model feature. The value of an isosurface can change in the object properties.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant