Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request corrects the plugin display name shown in OBS and addresses a potential resource leak in output handling.
Changes:
- Updated
obs_module_name()to return the correct plugin name ("Logitech G Plugin") instead of the integration name - Added proper release of OBS output resources in the loop function to prevent memory leaks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| obs_plugin/src/obs_plugin.hpp | Introduced s_plugin_name constant for consistent plugin naming |
| obs_plugin/src/obs_plugin.cpp | Updated module name function to use new constant and added output resource cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the plugin metadata and improves resource management in the OBS plugin implementation. The most important changes include correcting the plugin name used by OBS and ensuring proper release of OBS output resources.
Plugin metadata updates:
obs_module_name()inobs_plugin.cppto uses_plugin_nameinstead ofs_integration_name, ensuring OBS displays the correct plugin name.s_plugin_nameconstant ("Logitech G Plugin") to theloginamespace inobs_plugin.hppfor consistent naming.Resource management improvements:
obs_output_release(obs_output)in theloop_function()to properly release OBS output resources and prevent potential memory leaks.