fix/SaveLastOpenFilesList()

[Pr0metheus2]

Fix for clearing "LastOpenFilesList" on app exit.
When app closes, it looks like it wipes the set of files to restore.

Before exit:

After exit:

Also fixes two other places (both places are affected by this fix and should now work correctly):

• Close other tabs (LogTabWindow.cs:2326)
• Session-save file list (LogTabWindow.cs:2410)

[Hirogen]

looks good, but pls change your indent style from tab to spaces.
Pls also add a unit test for this case [TabControllerTests.cs] should be the right class

Also change the inner for to an foreach, the for is not needed

[Pr0metheus2]

Ok

[Pr0metheus2]

The indexed loop for DisplayingContents should be kept; it exposes displayed entries through its custom Count and indexer, while foreach uses the inherited ReadOnlyCollection enumerator and does not return the displayed tabs. The prior LINQ implementation had this failure and caused an empty LastOpenFilesList at shutdown.

[Hirogen]

As a side note, pls also add to the pr description:
this fixes also 2 other places "Close other tabs" [LogTabWindow.cs:2326] and session-save file list [LogTabWindow.cs:2410], both places are affected by this fix and should now work correctly

[Pr0metheus2]

All should be fixed as required.