Skip to content

Replace react-resizable#1154

Merged
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:replace-react-resizable
Jul 23, 2026
Merged

Replace react-resizable#1154
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:replace-react-resizable

Conversation

@CryZe

@CryZe CryZe commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

react-resizable depends on react-draggable, whose browser bundle references process.env.DRAGGABLE_DEBUG. Vite's development dependency optimizer leaves that Node-specific expression in the browser bundle, so starting a resize with npm run serve throws ReferenceError: process is not defined. This is tracked upstream in react-grid-layout/react-draggable#806.

Replace the dependency with a focused pointer-event implementation for the east, south, and southeast layout resize handles. Preserve the existing minimum dimensions and continue tracking drags outside the narrow handle hit areas.

Clean up document listeners when a drag ends, is canceled, loses focus, or the component unmounts. Remove react-resizable and its now-unused react-draggable transitive dependency.

`react-resizable` depends on `react-draggable`, whose browser bundle references
`process.env.DRAGGABLE_DEBUG`. Vite's development dependency optimizer leaves
that Node-specific expression in the browser bundle, so starting a resize with
`npm run serve` throws `ReferenceError: process is not defined`. This is tracked
upstream in [react-grid-layout/react-draggable#806](react-grid-layout/react-draggable#806).

Replace the dependency with a focused pointer-event implementation for the
east, south, and southeast layout resize handles. Preserve the existing minimum
dimensions and continue tracking drags outside the narrow handle hit areas.

Clean up document listeners when a drag ends, is canceled, loses focus, or the
component unmounts. Remove `react-resizable` and its now-unused
`react-draggable` transitive dependency.
@CryZe CryZe added enhancement A new feature or general improvement to LiveSplit One. UI The issue is about the user interface. high priority This is a high priority issue. dependencies Pull requests that update a dependency file code quality The goal is to improve the quality of the code. labels Jul 23, 2026
@CryZe CryZe linked an issue Jul 23, 2026 that may be closed by this pull request
@CryZe
CryZe enabled auto-merge (squash) July 23, 2026 14:09
@CryZe
CryZe merged commit 10eb2e5 into LiveSplit:master Jul 23, 2026
4 checks passed
@CryZe
CryZe deleted the replace-react-resizable branch July 23, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality The goal is to improve the quality of the code. dependencies Pull requests that update a dependency file enhancement A new feature or general improvement to LiveSplit One. high priority This is a high priority issue. UI The issue is about the user interface.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendor react-resizable

1 participant