Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Team Fortress–specific Module:InGameRoles data table so TF2 classes (and common aliases) are recognized as INGAME roles by Module:Role/Util, preventing them from being rendered as “unknown” roles (e.g., duplicative text badges alongside position icons).
Changes:
- Introduces
lua/wikis/teamfortress/InGameRoles.luadefining TF2 class roles (scout, soldier, demoman, medic, pyro, heavy, engineer, sniper, spy, pocket). - Adds role aliases matching the wiki’s
PositionIcon/datanaming (e.g.,solly/roamer→soldier,demo→demoman, etc.).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
75 tasks
mbergen
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Module:InGameRolesfor teamfortress so player classes (scout, soldier, demoman, medic, pyro, heavy, engineer, sniper, spy, pocket) are typed asINGAMEbyModule:Role/Util.Module:PositionIcon/data) and as a right-side text badge (since unknown-typed roles fall through to the non-ingame branch inWidget/Participants/Team/Roster).solly/roamer→ soldier,pocketsoldier/pocketsolly→ pocket,demo→ demoman,engi→ engineer,med→ medic.How did you test this change?
dev