Skip to content

feat: add InGameRoles for teamfortress#7565

Merged
Eetwalt merged 1 commit into
mainfrom
tf2-igr
May 27, 2026
Merged

feat: add InGameRoles for teamfortress#7565
Eetwalt merged 1 commit into
mainfrom
tf2-igr

Conversation

@Eetwalt
Copy link
Copy Markdown
Collaborator

@Eetwalt Eetwalt commented May 27, 2026

Summary

  • Add Module:InGameRoles for teamfortress so player classes (scout, soldier, demoman, medic, pyro, heavy, engineer, sniper, spy, pocket) are typed as INGAME by Module:Role/Util.
  • Without this, TeamParticipant rendered the class both as a left-side icon (via Module:PositionIcon/data) and as a right-side text badge (since unknown-typed roles fall through to the non-ingame branch in Widget/Participants/Team/Roster).
  • Includes the aliases present in the wiki's PositionIcon/data: solly/roamer → soldier, pocketsoldier/pocketsolly → pocket, demo → demoman, engi → engineer, med → medic.

How did you test this change?

dev

Copilot AI review requested due to automatic review settings May 27, 2026 10:04
@Eetwalt Eetwalt requested review from a team as code owners May 27, 2026 10:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Team Fortress–specific Module:InGameRoles data table so TF2 classes (and common aliases) are recognized as INGAME roles by Module:Role/Util, preventing them from being rendered as “unknown” roles (e.g., duplicative text badges alongside position icons).

Changes:

  • Introduces lua/wikis/teamfortress/InGameRoles.lua defining TF2 class roles (scout, soldier, demoman, medic, pyro, heavy, engineer, sniper, spy, pocket).
  • Adds role aliases matching the wiki’s PositionIcon/data naming (e.g., solly/roamersoldier, demodemoman, etc.).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Eetwalt Eetwalt merged commit 4f5cf05 into main May 27, 2026
8 checks passed
@Eetwalt Eetwalt deleted the tf2-igr branch May 27, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants