Skip to content

fix: Handle JSONDecodeError in deploy script #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rathoz merged 3 commits into from
May 27, 2026
Merged

fix: Handle JSONDecodeError in deploy script #7564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dd090e
fix: Handle JSONDecodeError in deploy script
mbergen May 27, 2026
33865a2
Improve error display
mbergen May 27, 2026
99d8771
Make the linter happy
mbergen May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions scripts/mediawiki_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,15 @@ def make_action(
print(f"data: {data}")
print(f"HTTP Status: {response.status_code}")
print(f'Raw response: "{response}"')
parsed_response: dict[str, Any] = response.json()
if "error" in parsed_response.keys():
raise MediaWikiSessionError(parsed_response["error"]["info"])
return parsed_response[action]
try:
parsed_response: dict[str, Any] = response.json()
if "error" in parsed_response.keys():
raise MediaWikiSessionError(parsed_response["error"]["info"])
return parsed_response[action]
except requests.JSONDecodeError:
raise MediaWikiSessionError(
f"{response.status_code} ({response.reason}): {response.text}"
)

def cooldown(self):
time.sleep(SLEEP_DURATION)
Expand Down
Loading