refactor: standings to widget3#7559
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the commons standings widgets to the widget3 functional component system (Module:Widget/Component), replacing the older Class.new(Widget) pattern and moving HTML tag construction to Module:Widget/Html.
Changes:
- Converted Standings Swiss/Ffa, RoundSelector, PlacementChange, and MatchOverview to functional components returned via
Component.component(...). - Switched HTML widget imports from
Module:Widget/Html/Allto the widget3 tag moduleModule:Widget/Html. - Inlined some previously-method-based helper logic (e.g., match result rendering and movement indicator selection).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/commons/Widget/Standings/Swiss.lua | Converts Swiss standings widget to widget3 component and reorganizes helper methods. |
| lua/wikis/commons/Widget/Standings/RoundSelector.lua | Refactors round selector to a functional component and uses widget3 HTML tags. |
| lua/wikis/commons/Widget/Standings/PlacementChange.lua | Refactors placement change indicator to widget3 component with defaultProps. |
| lua/wikis/commons/Widget/Standings/MatchOverview.lua | Refactors match overview display to widget3 component and inlines result rendering. |
| lua/wikis/commons/Widget/Standings/Ffa.lua | Converts FFA standings widget to widget3 component and updates HTML usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
ElectricalBoy
left a comment
There was a problem hiding this comment.
nitpick: all Widget return types should be updated to VNode (or Renderable)
Collaborator
Author
Did I miss any? |
Collaborator
|
I think you caught all with 60e88d5 |
ElectricalBoy
approved these changes
May 27, 2026
Collaborator
ElectricalBoy
left a comment
There was a problem hiding this comment.
lgtm (assuming tested)
hjpalpha
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Standings to Widget3
How did you test this change?