Skip to content

refactor: standings to widget3#7559

Merged
Rathoz merged 2 commits into
mainfrom
standings-widget3
May 27, 2026
Merged

refactor: standings to widget3#7559
Rathoz merged 2 commits into
mainfrom
standings-widget3

Conversation

@Rathoz
Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz commented May 27, 2026

Summary

Refactor Standings to Widget3

How did you test this change?

@Rathoz Rathoz requested review from a team as code owners May 27, 2026 06:16
Copilot AI review requested due to automatic review settings May 27, 2026 06:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the commons standings widgets to the widget3 functional component system (Module:Widget/Component), replacing the older Class.new(Widget) pattern and moving HTML tag construction to Module:Widget/Html.

Changes:

  • Converted Standings Swiss/Ffa, RoundSelector, PlacementChange, and MatchOverview to functional components returned via Component.component(...).
  • Switched HTML widget imports from Module:Widget/Html/All to the widget3 tag module Module:Widget/Html.
  • Inlined some previously-method-based helper logic (e.g., match result rendering and movement indicator selection).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lua/wikis/commons/Widget/Standings/Swiss.lua Converts Swiss standings widget to widget3 component and reorganizes helper methods.
lua/wikis/commons/Widget/Standings/RoundSelector.lua Refactors round selector to a functional component and uses widget3 HTML tags.
lua/wikis/commons/Widget/Standings/PlacementChange.lua Refactors placement change indicator to widget3 component with defaultProps.
lua/wikis/commons/Widget/Standings/MatchOverview.lua Refactors match overview display to widget3 component and inlines result rendering.
lua/wikis/commons/Widget/Standings/Ffa.lua Converts FFA standings widget to widget3 component and updates HTML usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/commons/Widget/Standings/Ffa.lua Outdated
Comment thread lua/wikis/commons/Widget/Standings/PlacementChange.lua Outdated
Comment thread lua/wikis/commons/Widget/Standings/Swiss.lua
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: all Widget return types should be updated to VNode (or Renderable)

Comment thread lua/wikis/commons/Widget/Standings/Ffa.lua Outdated
@Rathoz
Copy link
Copy Markdown
Collaborator Author

Rathoz commented May 27, 2026

nitpick: all Widget return types should be updated to VNode (or Renderable)

Did I miss any?

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

I think you caught all with 60e88d5

Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (assuming tested)

@Rathoz Rathoz merged commit 5bf66ea into main May 27, 2026
8 checks passed
@Rathoz Rathoz deleted the standings-widget3 branch May 27, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants