fix(match2): showsinglematch overwrites default width for match summaries#7545
Open
ElectricalBoy wants to merge 4 commits into
Open
fix(match2): showsinglematch overwrites default width for match summaries#7545ElectricalBoy wants to merge 4 commits into
ElectricalBoy wants to merge 4 commits into
Conversation
hjpalpha
approved these changes
May 23, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
lgtm modulo question in comment
| ---Display component for a match in a singleMatch. Consists of the match summary. | ||
| ---@param props {MatchSummaryContainer: function, match: MatchGroupUtilMatch, width: string|integer?} | ||
| ---@return Widget|Html | ||
| function SingleMatchDisplay.Match(props) |
Collaborator
There was a problem hiding this comment.
did you check this isn't called anywhere?
Collaborator
Author
There was a problem hiding this comment.
definitely not in Git-maintained modules
and non-Git modules should be using entrypoints defined in Module:MatchGroup anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported on discord: https://discord.com/channels/93055209017729024/684060921898860569/1507375882845687851
Regression from #7465
SingleMatch display has a fallback width of
400hardcoded as shown below:Lua-Modules/lua/wikis/commons/MatchGroup/Display/SingleMatch.lua
Line 54 in 286972d
This is problematic for any wiki that defines a default width other than 400 (e.g., VAL using default of 500px) in their
Module:MatchSummaryas the wiki default gets overwritten by the 400 shown above.This PR adjusts the width parsing to respect the wiki default, while keeping the fallback of
400.How did you test this change?
preview with dev