Skip to content

feat: SC2 birthdaylist#7524

Open
hjpalpha wants to merge 3 commits into
mainfrom
birthday-list
Open

feat: SC2 birthdaylist#7524
hjpalpha wants to merge 3 commits into
mainfrom
birthday-list

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

Summary

as title states

How did you test this change?

dev to live on sc2

@hjpalpha hjpalpha requested review from a team as code owners May 17, 2026 14:09
@hjpalpha hjpalpha added the g: starcraft Starcraft label May 17, 2026
@hjpalpha hjpalpha mentioned this pull request May 17, 2026
73 tasks
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fairly convinced that this could (should?) share some code with Module:ThisDay/Query

Comment thread lua/wikis/starcraft2/BirthdayList.lua Outdated
@hjpalpha
Copy link
Copy Markdown
Collaborator Author

I am fairly convinced that this could (should?) share some code with Module:ThisDay/Query

how so?
"ThisDay" conditions on month & day while this one here just queries all

Comment thread lua/wikis/commons/BirthdayList.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g: starcraft Starcraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants