feat(Infobox): Delta Force Infobox league#7442
Open
Hesketh2 wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
Export has been ticketed, so I should mark this as green ahead. |
hjpalpha
reviewed
May 17, 2026
Collaborator
Author
Collaborator
Collaborator
Author
Rathoz
reviewed
May 26, 2026
Comment on lines
+48
to
+49
| league.args.mode = MODES[(league.args.mode or 'default'):lower():gsub(' ', '')] | ||
| league.args.platform = PLATFORMS[(league.args.platform or 'default'):lower():gsub(' ', '')] |
Collaborator
There was a problem hiding this comment.
Entering an invalid platform or mode will cause a run time error here
Rathoz
reviewed
May 26, 2026
Comment on lines
+105
to
+106
| args.mode and (args.mode .. ' Competitions') or 'Tournaments without specified mode', | ||
| args.platform and (args.platform .. ' Tournaments') or 'Tournaments on unknown platforms', |
Collaborator
There was a problem hiding this comment.
With the parsing in the beginining, the fallbacks can never happen right?
Collaborator
Author
There was a problem hiding this comment.
Yeah, I'm thinking of removing the fixed text after or here since its no use
but combine with the other reviews regarding Runtime Error how should I edit it to prevent that error (say, if invalid platform is input then it just jumps back to the default instead so to stop errors from showing up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Delta Force is planned for next export in May
this new PR is a re-open of #7276 because those snapshot appearing I think it might have break PR (or require rebase?) so I close and re-open a new one, and I try to fix or update it again (much as I can with my limited coding knowledge)
DF's InfoLeague needs are: Modes Platforms and Patch
What I did in this version here is mostly patching how these three are done in other wikis together and maybe adjust it a bit. So will still need help here (maybe this is one is cleaner vs the previous)
Test
https://liquipedia.net/lab/Deltaforce/Pan-Pacific_Warfare_Cup/2026
Test modules will be removed from Lab post-export