Skip to content

feat(Infobox): Delta Force Infobox league#7442

Open
Hesketh2 wants to merge 7 commits into
mainfrom
H2-DF-League2
Open

feat(Infobox): Delta Force Infobox league#7442
Hesketh2 wants to merge 7 commits into
mainfrom
H2-DF-League2

Conversation

@Hesketh2
Copy link
Copy Markdown
Collaborator

@Hesketh2 Hesketh2 commented Apr 29, 2026

Summary

Delta Force is planned for next export in May

this new PR is a re-open of #7276 because those snapshot appearing I think it might have break PR (or require rebase?) so I close and re-open a new one, and I try to fix or update it again (much as I can with my limited coding knowledge)

DF's InfoLeague needs are: Modes Platforms and Patch

What I did in this version here is mostly patching how these three are done in other wikis together and maybe adjust it a bit. So will still need help here (maybe this is one is cleaner vs the previous)

Test

https://liquipedia.net/lab/Deltaforce/Pan-Pacific_Warfare_Cup/2026
Test modules will be removed from Lab post-export

@Hesketh2 Hesketh2 self-assigned this Apr 29, 2026
@Hesketh2 Hesketh2 marked this pull request as ready for review May 17, 2026 15:44
@Hesketh2 Hesketh2 requested review from a team as code owners May 17, 2026 15:44
@Hesketh2
Copy link
Copy Markdown
Collaborator Author

Export has been ticketed, so I should mark this as green ahead.

Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
@Hesketh2
Copy link
Copy Markdown
Collaborator Author

Hesketh2 commented May 21, 2026

Have one more help needed
image

Wiki was already exported so this can be tested on wider use, currently on empty inputs it will return two unknown categories, it did not use the two fixed test categories shown above, Is there a way to make it so if the mode and platform input returns unknown then showed the fixed text one as categories instead.

Right now it seems to treat Unknown as if another platform, but it exist just as a placeholder reason for events not putting it in infobox

image

@hjpalpha
Copy link
Copy Markdown
Collaborator

Have one more help needed image

Wiki was already exported so this can be tested on wider use, currently on empty inputs it will return two unknown categories, it did not use the two fixed test categories shown above, Is there a way to make it so if the mode and platform input returns unknown then showed the fixed text one as categories instead.

Right now it seems to treat Unknown as if another platform, but it exist just as a placeholder reason for events not putting it in infobox

image

isn't that the intended behavior?

@Hesketh2
Copy link
Copy Markdown
Collaborator Author

Have one more help needed image
Wiki was already exported so this can be tested on wider use, currently on empty inputs it will return two unknown categories, it did not use the two fixed test categories shown above, Is there a way to make it so if the mode and platform input returns unknown then showed the fixed text one as categories instead.
Right now it seems to treat Unknown as if another platform, but it exist just as a placeholder reason for events not putting it in infobox
image

isn't that the intended behavior?

Actuallly yeah you might be right, while im typing this I was originally thinking about these two highlighted text as categories if the input returns unknown on any of it

image

@Hesketh2 Hesketh2 changed the title feat(Infobox) : Delta Force Infobox league (wip) feat(Infobox) : Delta Force Infobox league May 22, 2026
@Rathoz Rathoz changed the title feat(Infobox) : Delta Force Infobox league feat(Infobox): Delta Force Infobox league May 26, 2026
Comment on lines +48 to +49
league.args.mode = MODES[(league.args.mode or 'default'):lower():gsub(' ', '')]
league.args.platform = PLATFORMS[(league.args.platform or 'default'):lower():gsub(' ', '')]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entering an invalid platform or mode will cause a run time error here

Comment on lines +105 to +106
args.mode and (args.mode .. ' Competitions') or 'Tournaments without specified mode',
args.platform and (args.platform .. ' Tournaments') or 'Tournaments on unknown platforms',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the parsing in the beginining, the fallbacks can never happen right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm thinking of removing the fixed text after or here since its no use
but combine with the other reviews regarding Runtime Error how should I edit it to prevent that error (say, if invalid platform is input then it just jumps back to the default instead so to stop errors from showing up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants