Skip to content

tests/ui-smoke: match the versioned python in coredumpctl #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandixximo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests/ui-smoke: match the versioned python in coredumpctl #4703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616a2e0
tests/ui-smoke: match the versioned python in coredumpctl
grandixximo Oct 19, 2026
c9b2331
tests/ui-smoke: find our own core in coredumpctl
grandixximo Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions tests/ui-smoke/_lib/crashdump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ crashdump_arm() {
export CORE_DIR
ulimit -c unlimited 2>/dev/null || true
crashdump_arm_time=$(date +%s)
# systemd-coredump keeps the environment of the crashed process, and
# its list is shared by every sandbox of a parallel run, so a core is
# ours only when it carries this tag.
UI_SMOKE_CRASH_TAG=$(cat /proc/sys/kernel/random/uuid)
export UI_SMOKE_CRASH_TAG
}

crashdump_report() {
Expand All @@ -43,9 +48,19 @@ crashdump_report() {
[ -e "$c" ] && [ -r "$c" ] && [ "$c" -nt "$CORE_DIR" ] && { core="$c"; break; }
done
fi
if [ -z "$core" ] && command -v coredumpctl >/dev/null 2>&1; then
if coredumpctl list --no-legend --since "@$crashdump_arm_time" python3 2>/dev/null | grep -q .; then
coredumpctl dump python3 --output="$CORE_DIR/core.coredumpctl" >/dev/null 2>&1 || true
# coredumpctl matches a path against the executable it recorded, which
# is the versioned interpreter (/usr/bin/python3.13), not the python3
# link or the GUI script name, so match the resolved path. The PID it
# records is the host one, so find our core by its tag and dump that.
local py pid
py=$(readlink -f "$(command -v python3)")
if [ -z "$core" ] && [ -n "$py" ] && command -v coredumpctl >/dev/null 2>&1; then
pid=$(journalctl -q -a -o json --output-fields=COREDUMP_PID,COREDUMP_ENVIRON \
--since "@$crashdump_arm_time" COREDUMP_EXE="$py" 2>/dev/null |
grep -F "UI_SMOKE_CRASH_TAG=$UI_SMOKE_CRASH_TAG" | tail -n 1 |
sed -n 's/.*"COREDUMP_PID":"\([0-9]*\)".*/\1/p')
if [ -n "$pid" ]; then
coredumpctl dump "$pid" --output="$CORE_DIR/core.coredumpctl" >/dev/null 2>&1 || true
[ -s "$CORE_DIR/core.coredumpctl" ] && core="$CORE_DIR/core.coredumpctl"
fi
fi
Expand All @@ -57,7 +72,7 @@ crashdump_report() {
-ex "bt" \
-ex "echo \n=== all threads ===\n" \
-ex "thread apply all bt" \
"$(command -v python3)" "$core" 2>&1 | head -400
"${py:-python3}" "$core" 2>&1 | head -400
else
# No readable core. The Python faulthandler traceback in
# linuxcnc.err already names the crash site; the native backtrace
Expand Down
Loading