Repository navigation
Conversation
Since the move to 64-bit HAL, halcmd reports types as bool, real, sint and uint. sim_pin only knew bit, float, s32 and u32, so it refused every pin, parameter and signal with 'Unknown type for signal item'. Rename the type names in the script, and the bit-named procs with them.
grandixximo
approved these changes
Oct 18, 2026
grandixximo
left a comment
grandixximo
left a comment
Contributor
There was a problem hiding this comment.
I tested this against master (64-bit HAL). Master sim_pin fails on every item with Unknown type for signal item <... bool>. With this PR it accepts bool, real, sint and uint signals and pins. Toggle and pulse work on bool, 2.5 and -7 round-trip on real and sint, a uint above 32 bits (5000000000) is set and shows correctly in hex, and a negative uint entry is still refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the move to 64-bit HAL (ff27543), halcmd reports types as
bool,real,sintanduint. sim_pin only knewbit,float,s32andu32, so it refuses every item, e.g. in the external_offsets sim:This renames the type names in the script (and the bit-named procs with them). The docs in hal/tools.adoc already use the new names.