Repository navigation
Conversation
…CNC#3627) program_units was only written by canon USE_LENGTH_UNITS, when the interpreter read a G20/G21 -- often far ahead of motion -- while gcodes reports the executing move. emcTaskUpdate now sets programUnits from the active G20/G21 it has just computed. Canon's write stays for interpreters that report no G20/G21 (canterp). tests/program-units runs a 5 s G21 move followed by G20 on simulated motion and fails if program_units disagrees with gcodes during the move. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3627.
While a program runs,
stat.program_unitsshould matchgcodes. Instead it follows the interpreter's read-ahead:Why:
gcodescomes from the executing move;program_unitswas set only when the interpreter read the G20.Fix:
emcTaskUpdate(src/emc/task/emctask.cc) setsprogramUnitsfrom the active G20/G21, as suggested on the issue. This keeps all C readers (linuxcncrsh, emcsh, shcom) consistent. Canon's write stays for canterp. Idle behaviour is unchanged.Test:
tests/program-unitsfails without the fix (every sample wrong: 670/670, 774/774, 853/853) and passes with it.Related: #3657.