gmoccapy: Fix reading [DISPLAY]CYCLE_TIME when wrongly set as a real - #4417
Open
BsAtHome wants to merge 1 commit into
Open
gmoccapy: Fix reading [DISPLAY]CYCLE_TIME when wrongly set as a real#4417BsAtHome wants to merge 1 commit into
BsAtHome wants to merge 1 commit into
Conversation
grandixximo
reviewed
Aug 19, 2026
BsAtHome
force-pushed
the
fix_gmoccapy-cycle-time
branch
from
August 19, 2026 13:28
c97ec4f to
d05aae7
Compare
BsAtHome
force-pushed
the
fix_gmoccapy-cycle-time
branch
from
August 19, 2026 16:26
d05aae7 to
773474d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several sims use the wrong
[DISPLAY]CYCLE_TIMEbeing set in seconds, whereas the docs say it is in milliseconds. The old INI read would cause an exception, which no longer happens. The new INI-file reader warns of trailing context and return the value zero (0). It will now test for existence and whether it is larger than 0. Otherwise the default is used.Also, the existence test "not val" should read "val is None", which has been fixed in two places where INI values are read and zero (0) is a valid value.
Fixes #4415
After discussion in #4415 gmoccapy now accepts both seconds and milliseconds bringing it in line with Axis.