Skip to content

fix: cast char to unsigned char in get_uint16 to prevent sign-extension #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
is-primary-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: cast char to unsigned char in get_uint16 to prevent sign-extension #4035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rtapi/uspace_rtapi_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ static void push_uint16(std::vector<char> &buf, uint16_t value) {

static uint16_t get_uint16(const std::vector<char> &buf, size_t idx) {
//at() will check index and throw std::out_of_range
return ((uint16_t)buf.at(idx) << 0) | ((uint16_t)buf.at(idx + 1) << 8);
return ((uint16_t)(unsigned char)buf.at(idx)) | ((uint16_t)(unsigned char)buf.at(idx + 1) << 8);
}

static bool recv_args(int fd, std::vector<std::string> &args) {
Expand Down
Loading