Fix generator methods in _DenseAdaBoostClassifier to use yield from instead of return#13
Merged
hamidkm9 merged 1 commit intoLinearBoost:mainfrom Jul 4, 2025
Conversation
_DenseAdaBoostClassifier to use yield from_DenseAdaBoostClassifier to use yield from instead of return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
_DenseAdaBoostClassifierwhere generator methods were incorrectly usingreturninstead ofyield fromwhen delegating to the parent class.Problem:
The staged methods (
staged_score,staged_predict,staged_decision_function,staged_predict_proba) were usingreturn super().method()which returns a generator object instead of yielding the values from the generator.Solution:
Changed
returntoyield fromfor all generator methods to properly delegate to the parent generator and yield values iteratively.Methods Fixed:
staged_scorestaged_predictstaged_decision_functionstaged_predict_probaThis ensures the staged methods work correctly as generators and maintain API compatibility with scikit-learn's
AdaBoostClassifier.