Skip to content

fix: harden transport fallback and UBSHM validation - #50

Merged
zchuango merged 3 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-round4
Sep 22, 2026
Merged

zchuango merged 3 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-round4

Conversation

@Spicy-cream

@Spicy-cream Spicy-cream commented Sep 18, 2026 •

Copy link
Copy Markdown

Summary

Address the latest review feedback on apache/brpc3535.

Changes

  • Avoid wrapping an inherited AdapterConnect more than once for pooled and short connections.
  • Unwrap inherited handshake connectors when a client-side high-speed upgrade is unavailable.
  • Publish TCP fallback for the client-side no-upgrade path.
  • Release RDMA and UBSHM resources immediately after server-handshake failure.
  • Reject unterminated UBSHM shared-memory names before resource allocation.
  • Add regression tests for connector wrapping, unavailable client upgrades, and malformed UBSHM names.

Validation

  • Build: passed.
  • Common transport handshake tests: 22/22 passed.
  • UBSHM/UBRING tests: 16/16 passed.
  • RDMA tests: 86/86 passed.

This PR targets the source branch used by apache/brpc3535.

@zchuango
zchuango merged commit 5664bf8 into LinQuickDev:transport-handshake Sep 22, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants