Fix root access being requested when not required#193
Open
6cUbi57z wants to merge 2 commits intoLidarr:developfrom
Open
Fix root access being requested when not required#1936cUbi57z wants to merge 2 commits intoLidarr:developfrom
6cUbi57z wants to merge 2 commits intoLidarr:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bash setup scripts were checking if the user was part of the
sudo/wheelgroups before checking if they were part of thedockergroup. This resulted in root access being requested when the user is part of thedockergroup where root access would not be required.Additionally, the code to determine the docker-compose command was looking for the
docker-composegroup which, to my knowledge, doesn't exist (or is non-standard). Checking for thedockergroup should suffice.Also fixes the docker compose service name in the dev file.