Repository navigation
Conversation
Match the canonical powerpc64 and powerpc64le CPU names so that VISUAL_ARCH_POWERPC enables the existing CPU and Linux AT_HWCAP AltiVec detection code. Keep the existing 32-bit PowerPC names.
Author
|
For context, the translation check fails before comparing catalogs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recognize the canonical
powerpc64andpowerpc64leCPU names in the existing PowerPC configure case.At present these hosts fall through to the unknown-architecture case, so
VISUAL_ARCH_POWERPCis not defined and the existing PowerPC CPU/AltiVec detection code is not enabled. This complements the LinuxAT_HWCAPimplementation from #268; it does not introduce a new probe or change the SDL code.The source change is limited to
libvisual/configure.ac.Validation
On the current upstream
0.4.xbase (12bdb54397dd), with this change:powerpc-linux-gnu,powerpc64-linux-gnu,powerpc64le-linux-gnu,ppc64-linux-gnuandppc64le-linux-gnuall defineVISUAL_ARCH_POWERPC. These name-mapping checks use native compilers; they are not PowerPC cross-builds.Earlier before/after testing of the same functional change against Debian's 0.4.2 source used GCC 16.2.0 and QEMU user-mode 11.1.3:
getauxval(AT_HWCAP). Defined exported-symbol lists are unchanged for both 64-bit targets.Those QEMU tests were performed on the Debian source, not rerun on the current upstream checkout, and are not real-hardware validation.
Local build caveat: a stock out-of-tree build failed in the generated PO Makefile (
/config.status), and an out-of-tree retry also exposed the examples' missing generated-header include path. The native verification above used an in-tree build with explicitmake top_builddir="$PWD". No build-system workaround is included in this PR.