feat(validation): support drag-and-drop PDF upload on the Validation page#7924
feat(validation): support drag-and-drop PDF upload on the Validation page#7924SAY-5 wants to merge 2 commits into
Conversation
…page Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
vitormattos
left a comment
There was a problem hiding this comment.
Could you also provide screenshot or demo video?
| </p> | ||
| <NcActions :menu-name="t('libresign', 'Validate signature')" :inline="3" :force-name="true"> | ||
| <NcActionButton :wide="true" :disabled="loading" @click="openUuidDialog()"> | ||
| <!-- TRANSLATORS: "UUID" is a unique technical identifier for a document (a code like '550e8400-e29b-41d4-a716-446655440000'). Keep "UUID" untranslated. --> |
There was a problem hiding this comment.
| <!-- TRANSLATORS: "UUID" is a unique technical identifier for a document (a code like '550e8400-e29b-41d4-a716-446655440000'). Keep "UUID" untranslated. --> | |
| <!-- TRANSLATORS "UUID" is a unique technical identifier for a document (a code like '550e8400-e29b-41d4-a716-446655440000'). Keep "UUID" untranslated. --> |
| @dragleave.prevent="handleDragLeave" | ||
| @drop.prevent="handleFileDrop"> | ||
| <p class="upload-dropzone__hint"> | ||
| {{ t('libresign', 'Drag and drop a PDF here, or use the buttons below.') }} |
There was a problem hiding this comment.
Should add TRANSLATORS tips here talking about the context and what's this.
| </template> | ||
| </NcActionButton> | ||
| <NcActionButton :wide="true" :disabled="loading" @click="uploadFile"> | ||
| {{ t('libresign', 'Upload') }} |
There was a problem hiding this comment.
Should add TRANSLATORS tips here talking about what's this.
|
Codecov Report❌ Patch coverage is
... and 172 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Congratulations on the initiative and your contribution to the project. How did you find out about LibreSign? |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
Added the TRANSLATORS hints for the drop-zone text and the Upload button, and kept the existing UUID note as-is (matches your suggestion). Pushed in 4e06d33. On the demo: the drag-and-drop area sits above the existing "From UUID"/"Upload" buttons on the Validation page. Dragging a PDF over it highlights the zone ( Found LibreSign while looking for a self-hosted Nextcloud-based signing app. |
|
Thanks for taking a look. I came across LibreSign while looking for a self-hostable, open-source document-signing option that integrates with Nextcloud, and the Validation page stood out as a place where drag-and-drop would smooth out the upload flow. On the demo: the change lets you drop a PDF anywhere on the Validation drop zone (in addition to the existing file picker). The drop zone shows an active/hover state while a file is dragged over it, rejects non-PDF files with the same validation the picker uses, and then runs the same validation request as a picker upload. I'll add a short screen recording of the drag-and-drop flow to the PR shortly. |
Resolves: #7923
📝 Summary
The Validation page only accepted a PDF through the Upload button. Users often expect the upload area to also accept a dragged file, and during testing a dropped PDF did nothing. This adds drag-and-drop over the upload area, reusing the existing validate flow. The Upload and From UUID buttons keep working as before.
🧪 How to test
🎨 UI / Front‑end changes
🚧 Tasks
✅ Checklist
🤖 AI (if applicable)