Repository navigation
test: cover what the plugin keeps after the webhook removal - #18
Merged
vitormattos merged 2 commits intoNov 14, 2026
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…ting Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #17.
What was wrong
#17 removes the webhook receiver and the fragment sync, which were the most covered part of the plugin. Line coverage drops from 65.5% (the last report of
main) to 45.4%, so the Coverage check failscurrent >= 65% && current >= prev. Most of what remains only runs with WooCommerce loaded, and the integration suite did not load it.What changed
vendor/test-plugins/and loaded before the plugin in the integration bootstrap, the same way as in woocommerce-nextcloud-admin-group-manager./my-account/alias and the checkoutorder-pay/order-receivedroutes, and when they are not registered;tests/Support/RedirectTrap.phpstops a redirect before theexitthat follows it and records where it pointed.No plugin code changes.
Verification
composer cigreen locally on PHP 8.3: lint, PHPCS, PHPStan and 170 tests. The unit suite still runs with no database. Line coverage: 367 of 481 lines, 76.3%.