Fix #1586: Fix PdfReader partial getPageSize by inheriting MediaBox and defaulting missing page boxes to Letter - #1611
Open
ganzah wants to merge 1 commit into
Open
Conversation
…diaBox and defaulting missing page boxes to Letter
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1586
Description of the Bugfix
Bug: PdfReader.getPageSize failed in partial-read mode when a page did not define its own MediaBox, because lazy page resolution did not apply inherited page-tree attributes and did not provide the existing Letter fallback used by full-read mode
Fix: Update partial page resolution in PageRefs.getSinglePage to merge inherited page attributes into the resolved leaf page and assign a Letter MediaBox when none exists anywhere in the hierarchy, making partial-read behavior consistent with full-read mode.
Unit-Tests for the Bugfix
New test class
PdfReaderPageSizeTest.javaadds tests for PdfReader#getPageSize both for "full read" mode and "partial read" mode. There are two tests for each mode: one the uses a synthetic pdf with a page that has no MEDIABOX attribute and one that uses a synthetic pdf that has no MEDIABOX attribute at all. The two tests for the "full read" mode work in the master branch, while the two tests for the "partial read" mode don't. All tests work in the branch with the bug fix.Compatibilities Issues
No known compatibility issues