Skip to content

fix(actions): make app signing use absolute paths #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Mar 31, 2026
+20 −12
Merged

fix(actions): make app signing use absolute paths #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/appstore-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,18 @@ jobs:

- name: Sign app
run: |
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${{ env.APP_NAME }}.key"
chmod 600 "${{ env.APP_NAME }}.key"
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
KEY_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.key"
CERT_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.crt"
APP_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"

printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${KEY_PATH}"
chmod 600 "${KEY_PATH}"
wget --quiet -O "${CERT_PATH}" "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"

php nextcloud/occ integrity:sign-app \
--privateKey="${{ env.APP_NAME }}.key" \
--certificate="${{ env.APP_NAME }}.crt" \
--path="${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
--privateKey="${KEY_PATH}" \
--certificate="${CERT_PATH}" \
--path="${APP_PATH}"

tar -C "${{ env.APP_NAME }}/build/artifacts" -zcf "${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}.tar.gz" "${{ env.APP_NAME }}"

Expand Down
16 changes: 10 additions & 6 deletions .github/workflows/nightly-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,18 @@ jobs:

- name: Sign app
run: |
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${{ env.APP_NAME }}.key"
chmod 600 "${{ env.APP_NAME }}.key"
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
KEY_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.key"
CERT_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.crt"
APP_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"

printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${KEY_PATH}"
chmod 600 "${KEY_PATH}"
wget --quiet -O "${CERT_PATH}" "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"

php nextcloud/occ integrity:sign-app \
--privateKey="${{ env.APP_NAME }}.key" \
--certificate="${{ env.APP_NAME }}.crt" \
--path="${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
--privateKey="${KEY_PATH}" \
--certificate="${CERT_PATH}" \
--path="${APP_PATH}"

tar -C "${{ env.APP_NAME }}/build/artifacts" -zcf "${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}.tar.gz" "${{ env.APP_NAME }}"

Expand Down
Loading