fix: convert from long RUN statements to a setup.sh script

[JohnVillalovos]

Convert the multiple RUN statements into a setup.sh bash script.

• Add a CI job to check the shell scripts.
• Resolve shellcheck issues with bin/*.sh
• Run shfmt -i 2 -ci -w bin/*sh

[Copilot]

Pull request overview

Removes the Dockerfile-level SHELL override (to avoid relying on a non-OCI instruction) and instead makes the heredoc RUN blocks explicitly run under bash, preserving pipefail behavior within those scripts.

Changes:

• Removed SHELL ["/bin/bash", "-o", "pipefail", "-c"] from the Dockerfile.
• Updated heredoc RUN blocks to invoke bash directly and set -o pipefail via set -xeuo pipefail.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[JohnVillalovos]

@colisee Do you prefer 2 space indents in bash files? I usually use 4, but I notice 'shfmt -i 4' caused a lot of changes.

Since most (but not all) was using 2 space indents I did that. And added a header to the files so that editors would know.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[ikke-t]

I assume apart from linter and while loop and dockerfile all are just white space changes?

I didn't test these, but read thrm through. Nothing apart removing setup.sh from container catches my eye.

[JohnVillalovos]

I have updated the PR and made shfmt use an indentation level of 2, as that is what was there before. So the diff is now simpler.

I assume apart from linter and while loop and dockerfile all are just white space changes?

Yes. That is correct.

Nothing apart removing setup.sh from container catches my eye.

Done

[Copilot]

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[colisee]

Aside from your comments, above, I tested a build with podman and ran a podman kube play and it worked like a charm.