Skip to content

Refactor keys and settings views with tabbed navigation - #46

Merged
Lftobs merged 2 commits into
devfrom
bugs-fixes
Sep 11, 2026
Merged

Refactor keys and settings views with tabbed navigation#46
Lftobs merged 2 commits into
devfrom
bugs-fixes

Conversation

@Lftobs

@Lftobs Lftobs commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Added tabbed Keys and Settings pages with clearer status summaries.
    • Added API key scopes, clipboard actions, SSH key uploads, key-type detection, and connection guides.
    • Added server connection method tabs and copyable agent commands.
    • Added SMTP provider presets, test-email controls, and GitHub setup guidance.
    • Added database storage summaries, connection-string copying, and refreshed provisioning flows.
    • Added shared environment variable visibility, normalization, and copy controls.
  • Bug Fixes

    • Docker Compose subprocesses now receive only explicitly configured project variables.
  • Deployment

    • API and web services now use published container images.

pages with tabbed navigation

- Update compose environment inheritance, refactor
  keys and settings views
  with modern dashboard components, hero headers,
  and tabbed layouts.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: be2ae40e-d532-4e87-b3d5-2537c92b6e5d

📥 Commits

Reviewing files that changed from the base of the PR and between 566f8b2 and 3e6f917.

📒 Files selected for processing (15)
  • apps/api/src/orchestrator/__tests__/compose.test.ts
  • apps/api/src/orchestrator/compose.ts
  • apps/web/src/components/databases/CreateDatabaseDialog.tsx
  • apps/web/src/components/databases/DatabaseCard.tsx
  • apps/web/src/components/settings/ApiKeysSection.tsx
  • apps/web/src/components/settings/GithubIntegrationSection.tsx
  • apps/web/src/components/settings/ServersSection.tsx
  • apps/web/src/components/settings/SharedEnvVarsSection.tsx
  • apps/web/src/components/settings/SmtpSection.tsx
  • apps/web/src/components/settings/SshKeyPoolSection.tsx
  • apps/web/src/routes/Databases.tsx
  • apps/web/src/routes/Keys.tsx
  • apps/web/src/routes/Settings.tsx
  • apps/web/src/routes/SharedEnv.tsx
  • docker-compose.yml

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

The PR isolates Docker Compose subprocess environments, redesigns database and settings interfaces, adds credential management workflows, updates shared environment handling, and switches Compose services to published GHCR images.

Changes

Compose environment isolation

Layer / File(s) Summary
Compose subprocess environment contract
apps/api/src/orchestrator/compose.ts, apps/api/src/orchestrator/__tests__/compose.test.ts
Docker Compose receives only explicit project variables. Tests verify that parent process variables are excluded and that missing project variables produce an empty environment.

Database and credential views

Layer / File(s) Summary
Database provisioning and lifecycle views
apps/web/src/components/databases/*, apps/web/src/routes/Databases.tsx
Database dialogs, cards, storage summaries, connection copying, lifecycle actions, loading states, and deletion dialogs receive updated layouts and labels.
API token and SSH key management
apps/web/src/components/settings/ApiKeysSection.tsx, apps/web/src/components/settings/SshKeyPoolSection.tsx, apps/web/src/routes/Keys.tsx
API token scopes, clipboard actions, token visibility controls, SSH key uploads, key-type detection, empty states, tables, revocation dialogs, and tabbed credential navigation are added.

Settings control plane

Layer / File(s) Summary
Settings route data and navigation
apps/web/src/routes/Settings.tsx
The settings route fetches server and integration status, shows summary cards, and places server, GitHub, and SMTP sections in tabs.
Server connection workflows
apps/web/src/components/settings/ServersSection.tsx
Server connection methods use tabs and toggleable forms. Agent registration commands can be copied. Server lists, preparation output, empty states, and removal dialogs are restyled.
GitHub and SMTP integration settings
apps/web/src/components/settings/GithubIntegrationSection.tsx, apps/web/src/components/settings/SmtpSection.tsx
GitHub setup guidance and secret visibility controls are added. SMTP presets, password visibility, configuration status, and test progress states are added.
Shared environment management
apps/web/src/routes/SharedEnv.tsx, apps/web/src/components/settings/SharedEnvVarsSection.tsx
Shared environment counts and precedence guidance are added. Variable keys are normalized, values can be revealed or copied, and forms, empty states, tables, and deletion dialogs are updated.

Published Compose images

Layer / File(s) Summary
Compose service image sources
docker-compose.yml
The API and web services use published GHCR images. Local build definitions remain commented out.

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Feature

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugs-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Lftobs
Lftobs merged commit e063837 into dev Sep 11, 2026
4 of 5 checks passed
@Lftobs
Lftobs deleted the bugs-fixes branch September 12, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant