Fix bug when exports the diagram to PNG. Let table original position when still overlaps after making all attemps.#563
Merged
brauliodiez merged 4 commits intoLemoncode:vnextfrom Nov 16, 2025
Conversation
brauliodiez
reviewed
Nov 1, 2025
| attempts++; | ||
| } | ||
|
|
||
| // If relocated table still overlaps, restore original posotion. |
Member
There was a problem hiding this comment.
Typo
Suggested change
| // If relocated table still overlaps, restore original posotion. | |
| // If relocated table still overlaps, restore original position. |
…s-overlap-wrong-behavior
Collaborator
Author
|
OK. Test ok. It fails for the original code, but with my modifications the test pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an algorythm to avoid table overlapping when the diagram is exported to PNG. If a table overlaps, is relocated to the left n positions. If the table still overlaps, is relocated again to the left n positions. If the table passes the canvas left border, then is relocated in the position n (table.x = n) and stays there. But very often, when the table width is big, overlaps a previous table, and the exported PNG looks very ugly. To avoid this bug we just let the table in its original position. An if block has been added to the end of the placeTableWithoutOverlap function, in the archive: src\pods\toolbar\components\export-button\export-button.business.ts