Repository navigation
fix(ladder): format timeline amounts, dates and enum labels - #820
Merged
Merged
Conversation
Table, filters, summary, snapshot, tooltip and editor showed raw 6-decimal USD strings, ISO timestamps and enum codes. Reuse formatCurrency, formatDate, formatTerm and getPaymentLabel; add a label map for layer and status enums that shows unknown codes raw. Dates render in UTC, amounts under $1 keep four digits, and absent snapshots read 'unavailable' rather than zero. Closes #697 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 43 minutes for your next included review. View limit details
Comment |
Member
Author
Independent merge-gate review: APPROVE at ad0a97eReviewer: independent gate agent (did not author this PR). Full diff vs origin/main reviewed (6 files, +132/-18). Checks
Local evidence (git archive of ad0a97e, macOS, under cc-heavy-run lock)
Non-blocking follow-ups (no change requested)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formats the ladder timeline for display (table, filters, summary, snapshot, tooltip, editor header) using the existing formatCurrency/formatDate/formatTerm/getPaymentLabel helpers plus a small layer/status label map. Unknown enum codes render raw. Dates are shown in UTC. Amounts under $1 show 4 digits; zero and absent stay distinct. Input values and filter option values keep the raw wire strings.
Tests: jest regression tests (hand-written fixtures, 3 fail on main), full jest, tsc, lint, build, Playwright ladder-timeline spec pass. ladder-config.spec fails as on main (#802), untouched.
Closes #697
Generated with Claude Code