Repository navigation
fix(frontend): keep zonal EC2 AZ in purchase variant identity and cell key - #809
Conversation
…l key Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 6 minutes for your next included review. View limit details
Comment |
|
Independent gate review (Opus 5.5): APPROVE at Scope reviewed: full diff (5 files, +34/-2) against origin/main; head contains main. Findings: none blocking.
Local verification (macOS,
CI at this SHA: all required checks green (CI Success, Run pre-commit hooks) plus Unit/Integration/E2E/Lint/Build/Security. Only failure is Playwright |
Part of #792 (PR3). Backend identity landed in #807; this keeps the frontend consistent with it.
What
samePurchaseVariantIdentitynow comparesdetails.availability_zonefor EC2/compute, so the purchase modal can no longer switch term/payment to a variant in a different AZ (the backend returns 409 for such a purchase). Regional recs have no AZ on either side and still match.cellKeyappends the AZ only when a rec has one, so zonal recs in different AZs are separate cells (and separate radio-selection groups) and every other cell key is unchanged.availability_zone?added toLocalRecommendationand the APIRecommendationtype.Ordering
Must merge with or before PR2b (the store change that lets AZ-only variants coexist); until then the backend can still hold only one row per 8-tuple.
Verification
availability_zonefrom the identity fields fails 2 tests; removing the cellKey suffix fails 1 test.🤖 Generated with Claude Code