Skip to content

Pin literal Archera signup URL in frontend archera tests (parity with #1280 Go fix) #49

Closed

Description

@cristim

Context

PR LeanerCloud/cloud-commitments-cli#1280 addressed a CodeRabbit nit on the Go side by pinning the literal Archera signup URL in TestPrintFinalMessage rather than relying on the archeraSignupURL constant. The same anti-regression rationale applies to the frontend tests in frontend/src/__tests__/archera.test.ts, which currently assert:

expect(link!.href).toBe(ARCHERA_SIGNUP_URL);

If ARCHERA_SIGNUP_URL is changed in frontend/src/archera.ts to a wrong destination (typo, accidental UTM, wrong domain), this test passes because the assertion compares against the same imported constant. The CodeRabbit finding on PR LeanerCloud/cloud-commitments-cli#1280: "Using archeraSignupURL here only proves the message prints whatever the production constant currently contains. It will not catch a regression where the constant changes to the wrong destination."

Acceptance criteria

  • In frontend/src/__tests__/archera.test.ts, add or replace at least one assertion per surface (offer modal + education page) with the literal canonical URL (https://www.archera.ai/cudly), so a future const change to a wrong destination is caught.
  • Keep the existing ARCHERA_SIGNUP_URL-referencing assertion as well, so the test continues to verify "code uses the exported const" alongside "const has the right value".
  • Confirm both partnership disclosures (non-gating + sponsorship — see project_archera_partnership memory) regression tests still pass.

Related

Activity

  1. IAmJSD commented on Oct 24, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions