fix(accounts): least-privilege accounts list for standard-user filter + plan prefill (closes #949, closes #951)

[cristim]

Summary

Fixes the Standard / Read-Only user account-access cluster (QA rows 547, 548, 550, 551). closes #949, closes #951.

Unified root cause: Standard / Read-Only groups lack view:accounts, so GET /api/accounts 403s for them, which broke two things:

• The global filter Account dropdown showed only "All Accounts" (fix(filter): Account dropdown empty for Standard/Read-Only users (missing view:accounts for global filter) #951, row 551).
• The create-plan-from-commitment Target Account could not be pre-filled (the per-id account fetch 403'd), so Save Plan silently no-opped behind the empty-target guard with no error (bug(plans): create-plan reported no success/error feedback (QA standard user) — verify vs deploy lag #949, rows 547/548).

Approach (option a, least-privilege)

Add a minimal-disclosure accounts source these users CAN call, without exposing sensitive account config (no role ARNs, subscription IDs, client emails, auth modes, or the self-account marker).

Backend

• New endpoint GET /api/accounts/list returning the minimal projection [{id, name, external_id, provider}], gated in-handler on view:recommendations (held by both Standard Users and Read-Only Users groups) rather than the admin-grade view:accounts. Scoped by allowed_accounts exactly like the full list. The full CloudAccount object (role ARNs, subscription IDs, client emails) stays behind view:accounts on GET /api/accounts.
• Route registered as an exact path before the generic /api/accounts/ GET prefix so "list" is not mistaken for an account :id.

Frontend

• Wired the topbar filter dropdown, the plan-account search, and the commitment-target prefill to a new api.listAccountsMinimal(). The prefill resolves the target client-side from the minimal list (no per-id endpoint needed).
• Plan-create error feedback was already wired (savePlan shows an error toast and keeps the modal open on failure); added a regression test asserting both halves of the bug(plans): create-plan reported no success/error feedback (QA standard user) — verify vs deploy lag #949 symptom.

Row 550 banner

• Corrected the nav name: "Settings → Users" -> "Admin → Users" (the tab was renamed from Settings in feat(frontend): UI revamp — restructure IA + visual reskin to action-center pattern #340).
• Scoped the message to the execute-purchases capability only, since Standard users CAN create and manage plans. Same fix applied to the identical history banner.

Endpoint authz

Endpoint	Verb gate	Standard user	Returns
GET /api/accounts/list (new)	view:recommendations	allowed	minimal {id, name, external_id, provider}, scoped
GET /api/accounts (unchanged)	view:accounts	403	full account config (admin-grade)

Tests

• Backend (internal/api/handler_accounts_test.go, ..._router_test.go): standard user allowed; full-list view:accounts user still 403s; no view:recommendations -> 403; allowed_accounts scoping; the JSON projection contains no sensitive fields; router dispatches /api/accounts/list to the minimal handler (not getAccount).
• Frontend: standard-user topbar dropdown populates from the minimal endpoint; plan modal prefills the target via the minimal list; save-failure shows an error toast AND keeps the modal open; row-550 banner copy assertions.

Verification

• gofmt -l clean, go vet ./internal/... clean, go build ./... OK.
• go test ./internal/api/ -> 1464 passed.
• npx tsc --noEmit clean; npx jest -> 2350 passed, 0 failed.
• SKIP=terraform_validate pre-commit run --all-files -> all passed (incl. the Go-defaults frontend-permissions regen, which made no changes).

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c9601f7a-8997-4482-accc-2b4d3e308e07

📥 Commits

Reviewing files that changed from the base of the PR and between 55739c2 and 8f0b975.

📒 Files selected for processing (15)

• frontend/src/__tests__/allowed-accounts.test.ts
• frontend/src/__tests__/api-accounts.test.ts
• frontend/src/__tests__/plans.test.ts
• frontend/src/__tests__/recommendations-permissions.test.ts
• frontend/src/__tests__/topbar-filters.test.ts
• frontend/src/api/accounts.ts
• frontend/src/api/index.ts
• frontend/src/history.ts
• frontend/src/plans.ts
• frontend/src/recommendations.ts
• frontend/src/topbar-filters.ts
• internal/api/handler_accounts.go
• internal/api/handler_accounts_router_test.go
• internal/api/handler_accounts_test.go
• internal/api/router.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/standard-user-account-access

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

@coderabbitai review