docs(security/azure): fix post-apply recipe (Consumption SKU) by cristim · Pull Request #184 · LeanerCloud/cloud-commitments-cli

cristim · 2026-04-28T20:57:31Z

Summary

Fixes the post-apply verification command in the security header comment of scheduled-tasks.tf. The original comment (added in PR #74) told operators to use az logicapp show, but that subcommand targets Logic Apps Standard (Microsoft.Web/sites with kind=workflowapp); these workflows are Consumption-tier (Microsoft.Logic/workflows via azurerm_logic_app_workflow). Running az logicapp show -n <wf> against one returns ResourceNotFound.

The replacement uses az resource show --resource-type Microsoft.Logic/workflows --api-version 2019-05-01, which:

Works against the right SKU.
Needs no az cli extension. (az logic workflow show does, and the logic extension can fail to install on Python 3.12+ azure-cli builds — the standard install path on macOS Homebrew today, which is exactly when an operator would reach for the post-apply check.)

Closes #183.

Scope

Comment-only — no resource, state, output, or runtime change. terraform fmt -check and terraform validate both clean (the pre-commit hooks ran them).

The two other surfaces called out in #183 (issue #50 "Steps to reproduce" and PR #74 "Test plan") are historical text — both will be addressed via corrective comments on those threads, not via code.

Test plan

terraform fmt -check clean (pre-commit Terraform format passed).
terraform validate clean (pre-commit Terraform validate passed).
CodeRabbit review with no actionable findings.

Summary by CodeRabbit

Documentation
- Clarified guidance for inspecting Azure Logic Apps: prefer the generic resource inspection command for Consumption-tier workflows rather than the Logic Apps Standard inspection command.
- Added a note that the Logic CLI extension may be required and that the workflow-inspection command can fail in some environments; emphasized that only Key Vault URLs are exposed and secrets are fetched at runtime.

cristim · 2026-04-28T20:57:37Z

@coderabbitai review

coderabbitai · 2026-04-28T20:57:43Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-28T20:57:45Z

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 9 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3f083b9-ed7b-4dfc-a3a5-7ddf72bbe1c9

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa6357 and 4b5ecba.

📒 Files selected for processing (1)

terraform/modules/compute/azure/container-apps/scheduled-tasks.tf

📝 Walkthrough

Walkthrough

Corrects an in-file Terraform comment to recommend using az resource show (for Microsoft.Logic/workflows) or az logic workflow show with the logic extension, instead of az logicapp show; no Terraform resources or logic were changed.

Changes

Documentation & Security Commentary

Layer / File(s)	Summary
Update scheduled-tasks.tf comment `terraform/modules/compute/azure/container-apps/scheduled-tasks.tf`	Updated comment to specify correct `az` CLI commands for Consumption-tier Logic Apps verification (`az resource show` vs `az logicapp show`), and added note that `az logic workflow show` requires the `logic` CLI extension. No Terraform resource logic modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

effort/s

Poem

🐰 A tiny hop to fix a line,
Commands aligned, the docs now shine.
From logicapp to resource we steer,
An extension note keeps operators clear.
Hooray — small change, no runtime fear!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: a documentation/comment-only fix to the post-apply verification recipe that corrects the command for Consumption-tier Logic Apps (Microsoft.Logic/workflows) in the scheduled-tasks.tf file.
Linked Issues check	✅ Passed	The PR fully addresses the primary objective from issue `#183` by updating the security header comment in scheduled-tasks.tf to use az resource show (Consumption-compatible, extension-free) instead of az logicapp show (Standard-only).
Out of Scope Changes check	✅ Passed	All changes are strictly within scope—only comment/documentation text was modified in scheduled-tasks.tf. No Terraform logic, resources, variables, or state changes were introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch docs/azure-post-apply-recipe

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cristim · 2026-05-19T15:10:11Z

@coderabbitai full review

coderabbitai · 2026-05-19T15:10:18Z

✅ Actions performed

Full review triggered.

cristim · 2026-05-22T11:25:07Z

@coderabbitai review

coderabbitai · 2026-05-22T11:25:14Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-22T22:51:36Z

@coderabbitai review

coderabbitai · 2026-05-22T22:51:41Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-27T16:45:29Z

@coderabbitai review

coderabbitai · 2026-05-27T16:45:35Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-27T18:20:18Z

@coderabbitai full review

coderabbitai · 2026-05-27T18:20:23Z

✅ Actions performed

Full review triggered.

cristim · 2026-05-27T22:25:02Z

@coderabbitai full review

coderabbitai · 2026-05-27T22:25:10Z

✅ Actions performed

Full review triggered.

cristim · 2026-05-28T11:57:13Z

@coderabbitai full review

coderabbitai · 2026-05-28T11:57:18Z

✅ Actions performed

Full review triggered.

cristim · 2026-05-30T10:27:38Z

@coderabbitai full review

coderabbitai · 2026-05-30T10:27:43Z

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 53 minutes and 59 seconds before sending another message.

cristim · 2026-06-04T14:04:54Z

@coderabbitai review

coderabbitai · 2026-06-04T14:04:59Z

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 38 minutes and 35 seconds before sending another message.

cristim · 2026-06-07T22:29:46Z

@coderabbitai full review

coderabbitai · 2026-06-07T22:29:51Z

✅ Action performed

Full review finished.

cristim · 2026-06-08T04:39:37Z

@coderabbitai full review

coderabbitai · 2026-06-08T04:39:42Z

✅ Action performed

Full review finished.

cristim · 2026-06-19T15:40:03Z

@coderabbitai review

coderabbitai · 2026-06-19T15:40:10Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-09T21:19:35Z

@coderabbitai review

coderabbitai · 2026-07-09T21:19:43Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-10T14:31:03Z

@coderabbitai review

coderabbitai · 2026-07-10T14:31:11Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

The header comment in scheduled-tasks.tf told operators to inspect the deployed workflow with `az logicapp show`, but `az logicapp` targets Logic Apps Standard (`Microsoft.Web/sites` with `kind=workflowapp`). These workflows are Consumption-tier (`Microsoft.Logic/workflows` via `azurerm_logic_app_workflow`); running `az logicapp show -n <wf>` against one returns ResourceNotFound. Replace with `az resource show --resource-type Microsoft.Logic/workflows --api-version 2019-05-01`, which works against the right SKU and needs no cli extensions (`az logic workflow show` does, and that extension can fail to install on Python 3.12+ azure-cli builds). Comment-only — no resource, state, or runtime change. Refs #183.

cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-sprint Within the current sprint impact/internal Team-internal only effort/xs Trivial / one-liner type/docs Documentation labels Apr 28, 2026

cristim changed the base branch from feat/multicloud-web-frontend to main June 9, 2026 15:52

cristim force-pushed the docs/azure-post-apply-recipe branch from 4b5ecba to d869b15 Compare June 19, 2026 15:40

cristim force-pushed the docs/azure-post-apply-recipe branch from d869b15 to 00969d5 Compare July 10, 2026 14:30

cristim force-pushed the docs/azure-post-apply-recipe branch from 00969d5 to ee31106 Compare July 17, 2026 18:32

cristim merged commit 9b020e8 into main Jul 19, 2026
19 checks passed

cristim deleted the docs/azure-post-apply-recipe branch July 27, 2026 11:09

Conversation

cristim commented Apr 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope

Test plan

Summary by CodeRabbit

Uh oh!

cristim commented Apr 28, 2026

Uh oh!

coderabbitai Bot commented Apr 28, 2026

Uh oh!

coderabbitai Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Uh oh!

cristim commented May 19, 2026

Uh oh!

coderabbitai Bot commented May 19, 2026

Uh oh!

cristim commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

Uh oh!

cristim commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 28, 2026

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

cristim commented May 30, 2026

Uh oh!

coderabbitai Bot commented May 30, 2026

Rate Limit Exceeded

Uh oh!

cristim commented Jun 4, 2026

Uh oh!

coderabbitai Bot commented Jun 4, 2026

Rate Limit Exceeded

Uh oh!

cristim commented Jun 7, 2026

Uh oh!

coderabbitai Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 19, 2026

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 10, 2026

cristim commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 7, 2026 •

edited

Loading

coderabbitai Bot commented Jun 8, 2026 •

edited

Loading

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading